fix(m-01): add salt to merkle leaf hashing #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadir-akhtar
approved these changes
Aug 6, 2025
ypatil12
merged commit b8458dd
into
release-dev/multichain-pt2-audit-fixes
5 checks passed
ypatil12
added a commit
that referenced
this pull request
Aug 8, 2025
**Motivation:** As part of an audit finding, to protect against [second preimage attacks](https://flawed.net.nz/2018/02/21/attacking-merkle-trees-with-a-second-preimage-attack/), we add a salt to the leaf similar to the RewardsCoordinator to significantly reduce the likelihood of an internal node being used to produce an unintentional proof. Layr-Labs/eigenlayer-contracts#1580 in core already did this on the cert verifier side. We now need to do this for table calc **Modifications:** - Inherit `LeafCalculatorMixin` in `BN254TableCalculatorBase` - Use `calculateOperatorInfoLeaf` **Result:** Secure code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of an audit finding, to protect against second preimage attacks, we add a salt to the leaf similar to the RewardsCoordinator to significantly reduce the likelihood of an internal node being used to produce an unintentional proof. Layr-Labs/eigenlayer-contracts#1580 in core already did this on the cert verifier side. We now need to do this for table calc
Modifications:
LeafCalculatorMixininBN254TableCalculatorBasecalculateOperatorInfoLeafResult:
Secure code