From 3a0653686964b4601c2a0a3b835a96cad9e69cb8 Mon Sep 17 00:00:00 2001 From: Amit Amrutiya Date: Sat, 18 Jan 2025 11:36:02 +0530 Subject: [PATCH 1/2] fix: share is not working issue Signed-off-by: Amit Amrutiya --- src/custom/ShareModal/ShareModal.tsx | 12 ++++++-- .../UserSearchField/UserSearchField.tsx | 30 ++++++++++--------- 2 files changed, 25 insertions(+), 17 deletions(-) diff --git a/src/custom/ShareModal/ShareModal.tsx b/src/custom/ShareModal/ShareModal.tsx index 6150249cd..86b1d5dd3 100644 --- a/src/custom/ShareModal/ShareModal.tsx +++ b/src/custom/ShareModal/ShareModal.tsx @@ -167,7 +167,6 @@ const ShareModal: React.FC = ({ handleShare, hostURL = null, handleCopy, - isVisibilitySelectorDisabled = false, fetchSuggestions }: ShareModalProps): JSX.Element => { @@ -221,7 +220,6 @@ const ShareModal: React.FC = ({ setOption(selectedResource?.visibility); } }, [selectedResource]); - return (
= ({ ) : ( )} @@ -289,7 +289,13 @@ const ShareModal: React.FC = ({ ))} - + {selectedOption === SHARE_MODE.PRIVATE ? options.PRIVATE : options.PUBLIC}
diff --git a/src/custom/UserSearchField/UserSearchField.tsx b/src/custom/UserSearchField/UserSearchField.tsx index 0132ab9d8..125e93940 100644 --- a/src/custom/UserSearchField/UserSearchField.tsx +++ b/src/custom/UserSearchField/UserSearchField.tsx @@ -1,5 +1,6 @@ import Autocomplete from '@mui/material/Autocomplete'; import CircularProgress from '@mui/material/CircularProgress'; +import { debounce } from 'lodash'; import React, { useState } from 'react'; import { Avatar, Box, Chip, Grid, TextField, Tooltip, Typography } from '../../base'; import { iconSmall } from '../../constants/iconsSizes'; @@ -88,21 +89,22 @@ const UserShareSearch: React.FC = ({ } }; - const handleInputChange = (_event: React.SyntheticEvent, value: string) => { - if (value === '') { - setOptions([]); - setOpen(false); - } else { - setSearchUserLoading(true); - fetchSuggestions(value).then((filteredData) => { - setOptions(filteredData); + const handleInputChange = debounce( + async (_event: React.SyntheticEvent, value: string) => { + if (value === '') { + setOptions([]); + setOpen(false); + } else { + setSearchUserLoading(true); + const suggestions = await fetchSuggestions(value); + setOptions(suggestions); setSearchUserLoading(false); - }); - setError(false); - setOpen(true); - } - }; - + setError(false); + setOpen(true); + } + }, + 300 + ); /** * Clone customUsersList component to pass necessary props */ From 5763094f033b2a401bfda3095c24a18b471542a7 Mon Sep 17 00:00:00 2001 From: Amit Amrutiya Date: Sat, 18 Jan 2025 11:37:55 +0530 Subject: [PATCH 2/2] feat: remove share changes Signed-off-by: Amit Amrutiya --- src/custom/ShareModal/ShareModal.tsx | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/custom/ShareModal/ShareModal.tsx b/src/custom/ShareModal/ShareModal.tsx index 86b1d5dd3..6150249cd 100644 --- a/src/custom/ShareModal/ShareModal.tsx +++ b/src/custom/ShareModal/ShareModal.tsx @@ -167,6 +167,7 @@ const ShareModal: React.FC = ({ handleShare, hostURL = null, handleCopy, + isVisibilitySelectorDisabled = false, fetchSuggestions }: ShareModalProps): JSX.Element => { @@ -220,6 +221,7 @@ const ShareModal: React.FC = ({ setOption(selectedResource?.visibility); } }, [selectedResource]); + return (
= ({ ) : ( )} @@ -289,13 +289,7 @@ const ShareModal: React.FC = ({ ))} - + {selectedOption === SHARE_MODE.PRIVATE ? options.PRIVATE : options.PUBLIC}