Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android always dropdown mode #163

Closed
sebqq opened this issue Mar 20, 2019 · 9 comments
Closed

Android always dropdown mode #163

sebqq opened this issue Mar 20, 2019 · 9 comments

Comments

@sebqq
Copy link

sebqq commented Mar 20, 2019

Hello, I'm encountering weird issue. In your examples there is always "modal" mode of picker ( when I run examples from expo on my Xiaomi mi 8, I'm getting modal mode), but when I copy/paste examples into my app, on android I always get "dropdown" mode picker. Even if I set prop {pickerProps: {mode: "modal"}} it is not doing anything and I'm always getting dropdown type of picker.

Is this normal behaviour?

Enclosing my code:

<RNPickerSelect
        placeholder={placeholderObject}
        items={itemsList}
        onValueChange={this.onValueChange}
        onClose={this.onDonePress}
        style={styles.pickerClassic}
        useNativeAndroidPickerStyle={false} // there is no difference when i set this to true
        value={this.state.currentValue}
        Icon={icon}
        pickerProps={{ mode: "dialog" }}
      />
@lfkwtz
Copy link
Collaborator

lfkwtz commented Mar 20, 2019

there is no mode: "modal" - it's either dialog or dropdown --- can you clarify which isn't working as expected?

@sebqq
Copy link
Author

sebqq commented Mar 20, 2019

I meant mode: "dialog",, sorry for that.. I would expect to get modal window, not dropdown menu when i open the picker. Even when I'm running example from expo, when I open the picker, modal is shown. But in my app, it always open picker items in dropdown instead of modal.

@lfkwtz
Copy link
Collaborator

lfkwtz commented Mar 20, 2019

Not sure. Can you update your original message to use the bug template?

And include a link to a github repo where this problem can easily be reproduced on an android device

@sebqq
Copy link
Author

sebqq commented Mar 20, 2019

Yep i will update it tomorow :) thanks for following up!

@lfkwtz
Copy link
Collaborator

lfkwtz commented Mar 21, 2019

Also - have you verified the issue occurs only on this package and not also on the native RN Picker?

@sebqq
Copy link
Author

sebqq commented Mar 26, 2019

My problem is related to this issue facebook/react-native#24055

@lfkwtz
Copy link
Collaborator

lfkwtz commented Mar 26, 2019

Good find on the upstream issue. This is precisely why we always stay one major version behind.

@lfkwtz lfkwtz closed this as completed Mar 26, 2019
@dantenol
Copy link

Any updates? it still opens as dropdpwn on RN v0.61.5 on an android device

@lfkwtz
Copy link
Collaborator

lfkwtz commented Feb 17, 2020

facebook/react-native#24055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants