Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: CUBA neuron normalization applied to current state #35

Merged
merged 8 commits into from
Feb 11, 2022

Conversation

bamsumit
Copy link
Contributor

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • Normalization implementation in CUBA had bug. It was applied to input value.

What is the new behavior?

  • Normalization is not applied to current dyanmics

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@bamsumit bamsumit requested review from mgkwill and srrisbud February 11, 2022 14:19
@bamsumit bamsumit self-assigned this Feb 11, 2022
@bamsumit bamsumit linked an issue Feb 11, 2022 that may be closed by this pull request
7 tasks
@mgkwill mgkwill merged commit 839a875 into lava-nc:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Salyer - Application of normalization function in CUBA neuron
3 participants