Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Annotations? #63

Open
alanhdu opened this issue May 11, 2023 · 1 comment
Open

Type Annotations? #63

alanhdu opened this issue May 11, 2023 · 1 comment

Comments

@alanhdu
Copy link

alanhdu commented May 11, 2023

I was wondering whether you'd be open to lifting the typestubs from typeshed (https://github.com/python/typeshed/tree/main/stubs/Deprecated/deprecated) directly into this repository. That would make the types easier to maintain (since they live with the code) and make it easier for users to consume (since they can get them directly when installing deprecated instead of having to install the separate types-deprecated module.

If you're open to this, I'd be happy to spend some time doing the port!

@tantale
Copy link
Collaborator

tantale commented May 27, 2023

Hi Alan,

Sorry for the late reply. Yes, I agree with adding the typestubs to Deprecated.

However, please make sure that this does not lead to regression with Python 2.7 as I want it to remain compatible (we still have users using this old version).

The best thing to do is to make a PR (on the develop branch) to prepare for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants