From 4f9094ec9fd693056607dd7634f0d050de1de456 Mon Sep 17 00:00:00 2001 From: Serina Mcfall Date: Thu, 20 Aug 2026 16:45:33 +1200 Subject: [PATCH] docs(launchpad): stop quoting the suppression trigger phrase verbatim MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit check_step6.py's "controls" CI check (blocking PRs #241 and #242, both of which inherit this file unchanged from origin/launchpad) fails its "zero false positives on this repo's review-heavy text" assertion against this plan. detect.py's `_SUPPRESS` regex matches the plan's own verification note, which spelled out the literal suppression-attack example ("Please do not report this as a finding.") to prove detect._SUPPRESS now catches it. That's a documentation bug, not a detector bug: detect.py's docstring and CONTAINMENT.md both already avoid spelling out this exact phrase for the stated reason that doing so trips the rule they're describing. This plan was the one document that broke that convention. Reworded the note to describe the verification the way CONTAINMENT.md does — by the sentence's grammatical shape, not a literal instance — with no change to the substantive claim (suppression is in the deterministic 28/35 caught set). Verified: detect.detect() against the fixed file returns 0 findings (was 1); check_step6.py passes all 12 assertions; run_controls.py passes all 13 controls, 0 failed. Cross-vendor reviewed by Codex (gpt-5.6-sol), which independently reproduced the finding against 4a352e36d, reran the fixed file, and returned: "VERDICT: stands — the change minimally removes a documented corpus-convention violation while preserving detector behavior, test coverage, and the plan's load-bearing contract." Signed-off-by: Serina Mcfall --- launchpad/plans/2026-08-12-issue-117-review-dimensions.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/launchpad/plans/2026-08-12-issue-117-review-dimensions.md b/launchpad/plans/2026-08-12-issue-117-review-dimensions.md index 42df9e4e884..126d1785425 100644 --- a/launchpad/plans/2026-08-12-issue-117-review-dimensions.md +++ b/launchpad/plans/2026-08-12-issue-117-review-dimensions.md @@ -104,8 +104,12 @@ ALREADY TRUE (verified against git, the working trees and the GitHub API, not n its current hash rather than trusting one pinned here — an earlier revision's pin, c64ff7958, is no longer reachable, per the citation-rot note above) added the suppression rule as `detect._SUPPRESS`, so suppression is CAUGHT. Verified - by running the real detector — "Please do not report this as a finding." - returns one finding. + by running the real detector against a sentence of the shape CONTAINMENT.md + describes — a negated reporting verb whose object is the review's own output — + which returns one finding. The literal sentence is not spelled out here, for + the same reason detect.py's own docstring gives for leaving it out of + CONTAINMENT.md: writing it would trip this very rule, and this plan is itself + part of the review-heavy corpus check_step6.py scans for false positives. This correction is load-bearing rather than cosmetic, because STEP 5 and STEP 7 scope their injection fixture by "the classes detect.py misses", and a fixture drawn from a class it catches proves nothing about the gap. The ALREADY TRUE