Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reuse of PgArguments #3695

Open
remysaissy opened this issue Jan 22, 2025 · 0 comments · May be fixed by #3687
Open

Allow reuse of PgArguments #3695

remysaissy opened this issue Jan 22, 2025 · 0 comments · May be fixed by #3687
Labels
enhancement New feature or request

Comments

@remysaissy
Copy link

I have found these related issues/pull requests

Closes #3687
Relates to #1736 (same but for MySQL and MsSQL).

Description

Hello,
I need to reuse the PgArguments in retry loops with query_with.
While this is possible with MySQL and MsSql thanks to #1736, it is currently not possible in PostgreSql.

Prefered solution

In my use case, I have a written a macro crate on top of sqlx to generate DML methods using derive directives.
It is similar to anorm and anorm-macros but using a more recent version of Sqlx.

Specifically on PostgresSql, Clone is missing from the PgArguments.
I've proposed a PR to implement this change here: #3687

Is this a breaking change? Why or why not?

It is not a breaking change as it does not modify the behaviour of PgArguments. It only adds the Clone capability to it.

@remysaissy remysaissy added the enhancement New feature or request label Jan 22, 2025
@remysaissy remysaissy linked a pull request Jan 22, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant