Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run tests if lvt file has spaces #249

Open
siefkenj opened this issue Sep 24, 2022 · 6 comments
Open

Cannot run tests if lvt file has spaces #249

siefkenj opened this issue Sep 24, 2022 · 6 comments
Labels

Comments

@siefkenj
Copy link

It appears that l3build save is not set up to run an lvt file with spaces in the name. It errors on the line

\input file with spaces.lvt

I am trying to write tests that work with \jobname when the jobname has spaces, so renaming my tests to not have spaces isn't an option.

@josephwright
Copy link
Member

I'm happy to look at the the naming-of-tests issue, but I wouldn't expect you to use the name of the test file as part of the test. For example, we need to test spaces in names, UTF-8 non-ASCII chars, etc., and do that in a test that is called something like space-test with an auxiliary file which has the space in the name.

@siefkenj
Copy link
Author

@josephwright I am not quite sure what you mean. How would an auxiliary file affect \jobname?

@josephwright
Copy link
Member

@siefkenj I mean that a test of something-with-filenames is not linked to 'jobname, it's just \input <whatever auxiliary file>; the setup is not intended to impart semantics to the names of the test files.

@josephwright
Copy link
Member

@zauguin, @FrankMittelbach Opinions here?

@FrankMittelbach
Copy link
Member

FrankMittelbach commented Nov 9, 2022

Personally I would just list it as a restriction on test file names. Sure one could guard the name everywhere but this is error prone and there isn't really a need for it (testing code with spaces in file names can easily be done by using your own file names (even those based on jobname) within the test.

@FrankMittelbach
Copy link
Member

ok, if you really have a package that internally uses \jobname and you want to test how that package behaves with spaces inside \jobname, that wouldn't work out of the box. However, that is a very singular case and you could test for it with something like

\def\jobname{foo bar}
\usepackage{mypkg}

or the like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants