Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error messages in the summary if reference file is missing? #243

Open
u-fischer opened this issue Sep 23, 2022 · 2 comments
Open
Assignees
Labels

Comments

@u-fischer
Copy link
Member

u-fischer commented Sep 23, 2022

The following is the output of small test setup: In testfiles are the tests a, b, c. The reference file for b is missing. In another testfolder with its own config is test d. The result of the check is then

$ l3build check
Running l3build with target "check" with configuration build
Running checks on
  a (1/3)
  b (2/3)
Error: failed to find any reference or expectation file for b!
Running l3build with target "check" with configuration config-extra
Running checks on
  d (1/1)

  All checks passed

Failed tests for configuration build:

  Check failed with difference files

As can be seen test c wasn't checked, and the summary doesn't say clearly that not all tests were checked, and it also doesn't say at which test the tests stopped.

@josephwright
Copy link
Member

I think this is more of a bug

@FrankMittelbach
Copy link
Member

well it is correct that there are no files that show diffs and there was no test made, ie there was no failed test either so it is kind of correct what it shows, it only forgets to tell you why it stopped. So I was trying to be kind and call it enhancing the product :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants