Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB change to differentiate containers and keys on secrets #164

Open
raildo opened this issue Apr 11, 2017 · 3 comments
Open

DB change to differentiate containers and keys on secrets #164

raildo opened this issue Apr 11, 2017 · 3 comments

Comments

@raildo
Copy link

raildo commented Apr 11, 2017

Nowadays, containers and keys are stored in the same table, the only difference between this two entities is that a container have an empty value in the DB.
To have a more robust solution, we should create a new flag or use PRAGMA on sqlite to distinguish between them.

@raildo raildo changed the title DB change to differentiate containers and keys to secrets DB change to differentiate containers and keys on secrets Apr 11, 2017
@simo5
Copy link
Member

simo5 commented Apr 11, 2017

If we can distinguish between a NULL value and an empty value that may also be sufficient, we cannot have keys with a NULL value, keys have at a minimum an empty value.

@simo5
Copy link
Member

simo5 commented Apr 11, 2017

But I think the interface we used may not be able to carry None (NULL) so that may be the issue and what we need to fix.

@simo5
Copy link
Member

simo5 commented Apr 11, 2017

(The other issue is upgrading the db schema)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants