Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleCredsAuth: support multiple uids or gids #117

Open
tiran opened this issue Feb 22, 2017 · 3 comments
Open

SimpleCredsAuth: support multiple uids or gids #117

tiran opened this issue Feb 22, 2017 · 3 comments
Milestone

Comments

@tiran
Copy link
Member

tiran commented Feb 22, 2017

SimpleCredsAuth is a bit inflexible and only supports checking of a single uid or gid. Access is allowed if user has either uid or gid as effective uid/gid. It would be rather simple to expand SimpleCredsAuth to support multiple uids and gids easily and have additional flag to switch from OR to AND. Access rule would be:

cred_euid in uids or cred_egid in gids

or

cred_euid in uids and cred_egid in gids

Perhaps a ExtendedCredsAuth class?

@simo5
Copy link
Member

simo5 commented Feb 22, 2017

I think just listing multiple ids is fine.
If both cred_quid and cred_egid are set then at least one of the uids and at least one of the gids must match, no need for complex and/or flags.

@tiran
Copy link
Member Author

tiran commented Feb 22, 2017

Do you prefer a new plugin or would you like me to add multiple ids to SimpleCredsAuth?

The SimpleCredsAuth has if self.gid == gid or self.uid == uid:.

@simo5
Copy link
Member

simo5 commented Feb 22, 2017

improve SimpleCredsAuth please

@tiran tiran added this to the future milestone Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants