Skip to content

Commit b92d66c

Browse files
committed
Add target to create a release build of Docker image
Release builds for Docker Hub are special snow flakes. A release build has to be tagged with a version number. We also want to start with the latest base image and refresh all layers to get security fixes. Signed-off-by: Christian Heimes <[email protected]>
1 parent 732fbb6 commit b92d66c

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

Makefile

+13-5
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ SERVER_SOCKET = $(CURDIR)/server_socket
77

88
DOCKER_CMD = docker
99
DOCKER_IMAGE = latchset/custodia
10+
DOCKER_RELEASE_ARGS = --no-cache=true --pull=true
11+
1012
CONTAINER_NAME = custodia_container
1113
CONTAINER_VOL = $(CURDIR)/vol
1214
CONTAINER_SOCKET = $(CONTAINER_VOL)/run/sock
@@ -93,11 +95,13 @@ release: clean egg_info README
9395
run: egg_info
9496
$(PYTHON) -m custodia.server $(CONF)
9597

96-
.PHONY = dockerbuild dockerdemo dockerdemoinit dockershell
98+
.PHONY: dockerbuild dockerdemo dockerdemoinit dockershell dockerreleasebuild
9799
dockerbuild:
98100
rm -f dist/custodia*.whl
99101
$(PYTHON) setup.py bdist_wheel
100-
$(DOCKER_CMD) build -f contrib/docker/Dockerfile -t $(DOCKER_IMAGE) .
102+
$(DOCKER_CMD) build $(DOCKER_BUILD_ARGS) \
103+
-f contrib/docker/Dockerfile \
104+
-t $(DOCKER_IMAGE) .
101105

102106
dockerdemo: dockerbuild
103107
@mkdir -p -m755 $(CONTAINER_VOL)/lib $(CONTAINER_VOL)/log $(CONTAINER_VOL)/run
@@ -124,6 +128,10 @@ dockerdemoinit:
124128
dockershell:
125129
$(DOCKER_CMD) exec -ti $(CONTAINER_NAME) /bin/bash
126130

127-
.PHONY=dockerpush
128-
dockerpush: dockerbuild
129-
docker push $(DOCKER_IMAGE)
131+
dockerrelasebuild:
132+
VERSION=$$($(PYTHON) -c \
133+
"import pkg_resources; print(pkg_resources.get_distribution('custodia').version)") && \
134+
$(MAKE) dockerbuild \
135+
DOCKER_BUILD_ARGS="$(DOCKER_RELEASE_ARGS)" \
136+
DOCKER_IMAGE="$(DOCKER_IMAGE):$${VERSION}" && \
137+
echo -e "\n\nRun: $(DOCKER_CMD) push $(DOCKER_IMAGE):$${VERSION}"

0 commit comments

Comments
 (0)