plot_alignment error?

lasy · lasy · commit 4820b9066c2d · 2024-06-21T15:08:56.000+02:00
diff --git a/.DS_Store b/.DS_Store
diff --git a/.gitignore b/.gitignore
@@ -10,3 +10,4 @@ inst/doc
 /Meta/
 *.icloud
 *.DS_Store
+.DS_Store
diff --git a/R/plot_alignment.R b/R/plot_alignment.R
@@ -436,6 +436,7 @@ plot_beta_layout <- function(x, subset = "all",
   } else if (length(subset) == 1 && subset == "all") {
     model_params <- model_params
   } else {
+    # TODO: throw an explicit error if subset is not part of the models
     model_params <- model_params[subset]
   }
 

Original file line number	Diff line number	Diff line change
`@@ -436,6 +436,7 @@ plot_beta_layout <- function(x, subset = "all",`
`436`	`436`	`} else if (length(subset) == 1 && subset == "all") {`
`437`	`437`	`model_params <- model_params`
`438`	`438`	`} else {`
	`439`	`+ # TODO: throw an explicit error if subset is not part of the models`
`439`	`440`	`model_params <- model_params[subset]`
`440`	`441`	`}`
`441`	`442`