Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests require de430.bsp kernel for testing #13

Open
medley56 opened this issue Feb 27, 2025 · 1 comment
Open

Unit tests require de430.bsp kernel for testing #13

medley56 opened this issue Feb 27, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@medley56
Copy link
Member

The de430.bsp kernel appeares to be required for some of the unit tests and is expected to be in data/generic. I suspect this is a large kernel and that's why it wasn't committed but we should either

  1. mock out the need for this kernel (probably unlikely)
  2. commit it despite its size (we could use LFS), or
  3. dynamically fetch/cache it from NAIF when it's needed.
@medley56 medley56 added the bug Something isn't working label Feb 27, 2025
@medley56
Copy link
Member Author

I see that the Dockerfile is pulling this in from NAIF for Dockerized testing. Could we do a similar thing using a pytest fixture so it's not dependent on running in Docker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant