This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Support inheritance for migration #1233
Assignees
Labels
enhancement 💡
New feature or request
migration
Migration of annotation to a new API version
released
Included in a release
Comments
Aclrian
added
enhancement 💡
Aclrian
added a commit
that referenced
this issue
Feb 16, 2023
Closes #1233. ### Summary of Changes - new additional differ, that compares only api elements whose parent classes are mapped onto each other or with a super- or subclass - improve flexibility for adding and changing and deleting differs in `run_migrate.py` by adding a constructor to AbstractDiffer - new methods for getting all the results or attributes of one api - remove distance_elements and used edit distance from levenshtein-api instead - hash function for subclasses of AbctractType and Parameter - fix possible runtime errors (RecursionError, NoneError) ### Testing Instructions run `migrate` command or `test_inheritance_differ.py`
|
🎉 This issue has been resolved in version 1.90.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is your feature request related to a problem?
Right now (#1190), the migration removes mappings in the 2nd interation (StrictDiffer) if the elements such as functions, attributes, … are moved to the related apiv2 sub-/super-class.
Desired solution
Create for a new (3rd) iteration a new differ. It should look for elements that are moved to a sub- or super-class and only compare those elements so that the api-mapper includes them in its mappings.
Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)
No response
The text was updated successfully, but these errors were encountered: