Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandatory update popup won't show after closing the app #426

Open
Kaizodo opened this issue Jul 16, 2024 · 4 comments
Open

Mandatory update popup won't show after closing the app #426

Kaizodo opened this issue Jul 16, 2024 · 4 comments
Labels
Candidate to be closed How To? This is a how to question need more information Further information is requested

Comments

@Kaizodo
Copy link

Kaizodo commented Jul 16, 2024

I am not sure this is a bug or a feature but here is how you can reproduce this situation

On a device if i set

UpgradeAlert(
      showIgnore: false,
     showLater: false,
child : Conainer())

this will disable closing the popup so it will make update mendatory however if user closes the app and reopens it popup did not show again and stays shut for default 3 days with this default setting in Upgrader class

  Duration durationUntilAlertAgain = const Duration(days: 3),

After 3 days later i will/should prompt again (i haven't test it)

so i think it if update is mendatory like showIgnore is false and showLater is false we should skip the later thing and keep update popup open until app is updated.

I have hope we are not saving ignored version when closing or starting the app otherwise alreadyIgnoredThisVersion() will return true and popup won't show even if we set durationUntilAlertAgain to Duration.zero

@Kaizodo Kaizodo changed the title Sometimes popup does not show Mandatory update popup won't show after closing the app Jul 18, 2024
@erdzan12
Copy link

Yes this should be something one could configure based on the needs, like to force users to update the app

@justatipfromthedeadsequoiatree
Copy link

justatipfromthedeadsequoiatree commented Aug 27, 2024

hi @erdzan12 @Kaizodo any update on this issue? thank you

#440

@phamgiaminh0112
Copy link

I have corrected this error and created a pull request. In that you just need to remove the isTooSoon() condition in file src/upgrader.dart line number 306. And don't forget to set showIgnore = false and showLater = false if you don't want users to skip the update.

@larryaasen
Copy link
Owner

Did you try using durationUntilAlertAgain with Upgrader and setting it to Duration(seconds: 0)?

@larryaasen larryaasen added need more information Further information is requested Candidate to be closed How To? This is a how to question labels Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Candidate to be closed How To? This is a how to question need more information Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants