[3.x] feat: allow to customise the signature_method #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankurk91
commented
Apr 30, 2023
src/VonageChannelServiceProvider.php
Outdated
| @@ -22,8 +22,6 @@ public function register() | |||
| $this->app->singleton(Client::class, function ($app) { | |||
| $config = $app['config']['vonage']; | |||
|
|
|||
| $httpClient = null; | |||
There was a problem hiding this comment.
This line was unused always since the variable is being initialised in the very next line.
This change is not related to the new feature introduced .
driesvints
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Vonage allows us to customise the signature method (algo) through their dashboard (see screenshot), the default value is set to
HMAC_SHA256.This package was hard coded to use
md5hash, this PR introduce a new config keysignature_methodwhich allows us to override the parameter.Vonage uses this algorithm to sign the incoming webhooks as well as outgoing SMS via the SDK.
PS.
I have kept backward compatibility, the default algo in sdk is still the same.