New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dx: bind VonageSmsChannel to container #63

Merged

taylorotwell merged 1 commit into laravel:3.x from ankurk91:feat/bind-channel

Oct 12, 2022

Contributor

ankurk91 commented Oct 12, 2022

Hi @driesvints ,

This change allow us to specify the channel class in Notification via() method.

use Illuminate\Notifications\VonageSmsChannel;

public function via() {
   return [VonageSmsChannel::class]
}

The old syntax will still work

public function via() {
   return ['vonage']
}

This helps us to CTRL+Click on class name and jump to actual class


          feat: bind VonageSmsChannel to container

f161e07

taylorotwell merged commit f073101 into laravel:3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet