Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #13, this implements shortcode support with Nexmo. Pulled this out of our app to break off into a package but would be better in the official notification channel.
A couple of notes: -
I called the channel
shortcode
for brevity, but it isn't quite as "namespaced" as thenexmo
channel. I'm not sure there is a precedent for multi-word channel names - wouldnexmo-shortcode
be better?At the moment I've implemented it with support for an array which
Nexmo\Message\Shortcode
will adapt into an instance under the hood. Would you want me to implement a fluent interface to build up a shortcode message as well?I added a base TestCase that uses
MockeryPHPUnitIntegration
- this fixes an issue with PHPUnit complaining that the tests didn't actually perform any assertions (despite the fact they set expectations on mocks).Happy to sort out a PR for the docs as well if you decide to bring this in.