Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Implement shortcode support #24

Merged
merged 3 commits into from
Sep 30, 2019
Merged

[2.x] Implement shortcode support #24

merged 3 commits into from
Sep 30, 2019

Conversation

dwightwatson
Copy link
Contributor

As suggested in #13, this implements shortcode support with Nexmo. Pulled this out of our app to break off into a package but would be better in the official notification channel.

A couple of notes: -

  • I called the channel shortcode for brevity, but it isn't quite as "namespaced" as the nexmo channel. I'm not sure there is a precedent for multi-word channel names - would nexmo-shortcode be better?

  • At the moment I've implemented it with support for an array which Nexmo\Message\Shortcode will adapt into an instance under the hood. Would you want me to implement a fluent interface to build up a shortcode message as well?

  • I added a base TestCase that uses MockeryPHPUnitIntegration - this fixes an issue with PHPUnit complaining that the tests didn't actually perform any assertions (despite the fact they set expectations on mocks).

1) Illuminate\Tests\Notifications\Channels\NexmoShortcodeChannelTest::testShortcodeIsSentViaNexmo
This test did not perform any assertions

Happy to sort out a PR for the docs as well if you decide to bring this in.

@driesvints driesvints changed the title Implement shortcode support [2.x] Implement shortcode support Sep 25, 2019
@taylorotwell taylorotwell merged commit b6f945a into laravel:2.0 Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants