Update to use newest version of nexmo/laravel #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This may be better suited for
master
. I'm not sure if Laravel considers this a BC-breaking change or not, since the underlying package is being changed.)This switches this library over to using the
nexmo/laravel
package, and brings everything up to the 2.x line.Switching to the
nexmo/laravel
allows the Nexmo client to be pulled directly from the Service Container, as opposed to being instantiated directly in the Channel Service Provider.nexmo/laravel
also ships a Facade, giving the developers the option to use the Service Container or Facades to pull in a valid package if they want to use Nexmo in other places in their application.We're recommending Laravel switch to use
nexmo/laravel
as it also gives users a workaround in case they run into GuzzleHTTP collisions in the future (see https://github.com/Nexmo/nexmo-php/issues/5).nexmo/laravel
can easily be overridden to use a different HTTPlug-compatible adapter, where directly creating a\Nexmo\Client
makes it much harder to override.Both
laravel/nexmo-notification-channel
andnexmo/laravel
use the same.env
options, so this should be a drop-in replacement for users.