Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Client Ref on the Nexmo API #17

Merged
merged 4 commits into from
Jul 29, 2019
Merged

Support for Client Ref on the Nexmo API #17

merged 4 commits into from
Jul 29, 2019

Conversation

Braunson
Copy link
Contributor

As per #14 with fixed code style, fixed tests, added new test with client ref

@taylorotwell taylorotwell merged commit 638d1cc into laravel:2.0 Jul 29, 2019
@driesvints
Copy link
Member

@Braunson I know it's been quite a while since this PR was merged but did you test this? Seems like the key should be client-ref and not client_ref? See #43

@driesvints driesvints mentioned this pull request Dec 21, 2020
Closed
@Braunson Braunson mentioned this pull request Dec 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Braunson @driesvints @taylorotwell