Add frankenphp binary to IgnoredFiles while BuildProcess #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rvzug, wondering if we can do this in the same way as we do for Roadrunner instead? https://github.com/laravel/vapor-cli/pull/191/files |
|
That also works fine :-) |
|
Thank you! |
joedixon
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While following the default installation-instructions of
You'll end up with the 'frankenphp' binary file in your application root. This file will be added to the Deployment Artifact resulting in a possible to big artifact for AWS Lambda. Resluting in a error while deploying:
This PR adds the binary to the ignored files while building the artifact