Abort if creating an environment called "testing" #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanfreitasdev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request notifies the user that we should avoid referring to an environment as "testing"
When calling the environment "testing", we may have problems during deployment if any code has the "
app()->runningUnitTests();" check.The problem is caused in the
SetBuildEnvironmentfile on line 66 when doing this:vapor-cli/src/BuildProcess/SetBuildEnvironment.php
Line 66 in 0563148
Therefore, if the user environment calls testing, vapor will add
APP_ENV=testingand the deployment will fail.I don't believe it needs to change in "
SetBuildEnvironment", why the name "testing" should be abolished instead of checking the environment.I believe we also need to document