Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported Docker images to match documentation #239

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Update supported Docker images to match documentation #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e5eda1
Update supported Docker images to match documentation
lhilton Nov 5, 2023
e592083
Updated test to recognize php83 docker containers
lhilton Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/BuildProcess/BuildContainerImage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class BuildContainerImage
'laravelphp/vapor:php80',
'laravelphp/vapor:php81',
'laravelphp/vapor:php82',
'laravelphp/vapor:php83',
];

/**
Expand All @@ -35,6 +36,7 @@ class BuildContainerImage
*/
public static $armImages = [
'laravelphp/vapor:php82-arm',
'laravelphp/vapor:php83-arm',
];

/**
Expand Down
4 changes: 2 additions & 2 deletions tests/BuildContainerImageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ public function runtimeProvider()
'docker',
'FROM laravelphp/vapor:php83',
[],
false,
true,
],
[
'docker-arm',
Expand All @@ -208,7 +208,7 @@ public function runtimeProvider()
'docker-arm',
'FROM laravelphp/vapor:php83-arm',
[],
false,
true,
],
[
'docker-arm',
Expand Down