-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Pest in vapor test
#233
Conversation
Thanks for sending this in @owenvoke, I think it makes a lot of sense to support Pest here. I'm in the process of jumping on the PR as I think I'd prefer to try and make the Did you manage to successfully test the PR locally? |
Hi @joedixon 👋🏻 I managed to test this successfully locally, I basically just went to another project using Pest and ran What error are you getting? Actually, it's not working, because it's running the |
This is the same issue I'm seeing. I can fix this by adding |
@owenvoke just pushed some updates to support the Summary of changes:
The last point is not bullet proof as the arguments have to be in the correct order (e.g. |
I've tested this change locally, and it seems to work great. 🙌🏻 My only thought is the same as your last point, I'm not a huge fan about requiring specific orders. But not sure of a good solution to this. 🤷🏻 As far as I can tell, this will work in the same way as before. 👍🏻 |
This adds support for Pest when using the
vapor test
command. It does this based on the existance of thevendor/bin/pest
binary, however, I'm not sure whether we want to use a--pest
flag (which was my initial attempt, but it seemed awkward with thearray_splice()
, and I didn't want to make too many changes).