Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Provide helpful error messaging for insufficient .yml options #203

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

ahinkle
Copy link
Contributor

@ahinkle ahinkle commented Nov 18, 2022

When creating a blank vapor.yml file and attempting to deploy, you receive type errors:

Warning: Trying to access array offset on value of type null in /laravel-app/vendor/laravel/vapor-cli/src/Manifest.php on line 16

Fatal error: Uncaught TypeError: Laravel\VaporCli\ConsoleVaporClient::validateManifest(): Argument #3 ($manifest) must be of type array, null given, called in /laravel-app/vendor/laravel/vapor-cli/src/Commands/DeployCommand.php on line 91 and defined in /laravel-app/vendor/laravel/vapor-cli/src/ConsoleVaporClient.php:1121

This PR provides a helpful error message when these values are missing. Also, don't create Vapor config files while eating breakfast. 😆

@ahinkle ahinkle changed the title Provide helpful error messaging for insufficient .yml options [1.x] Provide helpful error messaging for insufficient .yml options Nov 18, 2022
@taylorotwell taylorotwell merged commit e92b272 into laravel:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants