Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature to not overwrite existing handlers if found in core application #170

Merged
merged 4 commits into from
Feb 5, 2022

Conversation

jaxwilko
Copy link
Contributor

@jaxwilko jaxwilko commented Feb 4, 2022

This PR introduces a simple change that allows for handlers to be embedded within the application and prevents vapor-cli from replacing them upon deployment.

Usage

In WinterCMS (a Laravel powered CMS) we utilise our own autoload.php which allows us to load our custom helpers before composer loads those provided by Laravel.

The core issue (being able to autoload files in a specific order) was recently closed by composer:
composer/composer#6768

Unfortunately when deploying with Vapor, the httpHandler.php is injected which calls:

require __DIR__.'/vendor/autoload.php';

This means that our application helpers are replaced by the core Laravel ones.

@taylorotwell taylorotwell merged commit 0818a5d into laravel:master Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants