Add option to force environment and database deletion #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the idea of integrating Vapor even further in automations, I propose to add
--forceoption to bothdatabase:deleteas well asenv:deleteAt the moment these cannot be automatically deleted because they have a
Helper::confirm()gate keeping the action.I understand the risks of such option but I believe it's meant to be used wisely, as the description of the command details.
CHANGELOG
--forcetodatabase:deletecommand, allowing to over-pass confirmation. Example:php vendor/bin/vapor database:delete database-name --force--forcetoenv:deletecommand, allowing to over-pass confirmation. Example:php vendor/bin/vapor env:delete environment-name --force