Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SameSite attribute for cookies are not being added #298

Closed
sikhlana opened this issue May 28, 2021 · 0 comments · Fixed by #299
Closed

SameSite attribute for cookies are not being added #298

sikhlana opened this issue May 28, 2021 · 0 comments · Fixed by #299
Labels
bug

Comments

@sikhlana
Copy link
Contributor

  • Octane Version: 1.0.2
  • Laravel Version: 8.43.0
  • PHP Version: 8.0.6
  • Server & Version: Swoole 4.6.4

Description:

While using Octane, the cookies don't include the SameSite attribute even if explicitly set in config/session.php -> same_site.

Steps To Reproduce:

  1. Create a controller that queues a cookie.
  2. Explicitly set the same_site config field to something like 'lax', 'strict' or 'none'
  3. Start the octane process
  4. Call the route with the browser of your choice with network monitoring enabled
  5. Check that the cookie does not have the ; samesite= added in the headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[1.x] Adds SameSite attribute for cookies sikhlana/laravel-octane
2 participants
@driesvints @sikhlana