Wrong resource count when using $query->groupBy()

[robertvrabel]

• Laravel Version: 5.7.20
• Nova Version: 1.3.0
• PHP Version: 7.2

Description:

Using $query->groupBy('id'); displays the incorrect count at the bottom of the resource listing.

Steps To Reproduce:

Use $query->groupBy('id'); in your indexQuery() with a join and you will see the incorrect count.

Fix

I found a solution in nova/src/Http/Controllers/ResourceCountController

Original

return response()->json(['count' => $request->toQuery()->count()]);

Fix

return response()->json(['count' => $request->toQuery()->get()->count()]);

I am not sure if that is the best solution, but I had found it file from this issue: laravel/framework#22883

[bonzai]

Duplicate of #625

[robertvrabel]

@bonzai The issue I filed is quite different than the duplicate you are referring to. I do NOT have a problem with conflicting names. My problem is the resource count at the bottom is incorrect. Refer to this image:

[bonzai]

If you change Laravel\Nova\Http\Controllers\ResourceCountController::show() to:

public function show(ResourceIndexRequest $request)
{
    $count = $request
        ->toQuery()
        ->toBase()
        ->getCountForPagination();

    return response()->json(['count' => $count]);
}

Will this fix your issue?

Also, please paste your database structure and query from the indexQuery() method.

[robertvrabel]

@bonzai Yes that seems to fix it!

My query is:

"select * from `articles` inner join `application_article` on `id` = `application_article`.`article_id` where `application_article`.`application_id` in (?, ?) and `articles`.`deleted_at` is null group by `id` order by `articles`.`id` desc"

Article table:

CREATE TABLE `articles` (
  `id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `user_id` int(10) unsigned NOT NULL,
  `favicon_id` int(10) unsigned DEFAULT NULL,
  `application_id` int(10) unsigned DEFAULT NULL,
  `title` varchar(255) NOT NULL,
  `short_title` varchar(255) NOT NULL,
  `sub_title` varchar(255) DEFAULT NULL,
  `permalink` varchar(255) NOT NULL,
  `status` varchar(255) NOT NULL,
  `link` varchar(255) DEFAULT NULL,
  `body` text,
  `article_date` date NOT NULL,
  `created_at` timestamp NULL DEFAULT NULL,
  `updated_at` timestamp NULL DEFAULT NULL,
  `deleted_at` timestamp NULL DEFAULT NULL,
  PRIMARY KEY (`id`),
  KEY `articles_user_id_foreign` (`user_id`),
  KEY `articles_favicon_id_foreign` (`favicon_id`),
  KEY `articles_application_id_foreign` (`application_id`),
  CONSTRAINT `articles_application_id_foreign` FOREIGN KEY (`application_id`) REFERENCES `applications` (`id`),
  CONSTRAINT `articles_favicon_id_foreign` FOREIGN KEY (`favicon_id`) REFERENCES `favicons` (`id`),
  CONSTRAINT `articles_user_id_foreign` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

Application pivot table:

CREATE TABLE `application_article` (
  `application_id` int(10) unsigned NOT NULL,
  `article_id` int(10) unsigned NOT NULL,
  `created_at` timestamp NULL DEFAULT NULL,
  `updated_at` timestamp NULL DEFAULT NULL,
  KEY `application_article_application_id_index` (`application_id`),
  KEY `application_article_article_id_index` (`article_id`),
  CONSTRAINT `application_article_application_id_foreign` FOREIGN KEY (`application_id`) REFERENCES `applications` (`id`) ON DELETE CASCADE,
  CONSTRAINT `application_article_article_id_foreign` FOREIGN KEY (`article_id`) REFERENCES `articles` (`id`) ON DELETE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

[davidhemphill]

This has been fixed and will be included in the next release. 👍

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.