[2.x] Fix shortcode messaging with the latest version of nexmo-client #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest release(s) of
nexmo-client
(v2.2.0+) they've made some changes internally, which affect howNexmo\Message\Client
uses theNexmo\Client
that is passed into it. This breaks the ability to send shortcodes when you have the latest versions ofnexmo-client
.Previously I used the container to create a new instance of
Nexmo\Message\Client
and Laravel was being smart and giving it an instance of an optional dependency. However, this optional dependency now overrides the customNexmo\Client
we're setting here.The easy fix is to just not provide the optional dependency and new up the instance as-is. Alternatively I could register it directly with the service provider so it knows not to pass any dependency but that felt like overkill in this instance.