HasAttributes->isRelation() returns wrongly TRUE when a new style Accessor is present

[jozydapozy]

• Laravel Version: 9.0.2
• PHP Version: 8.0.15

Description:

When calling isRelation() on a model, to test if a certain key is a relation, the function returns wrongly true when a Accessor-method is present.

Steps To Reproduce:

<?php
 
namespace App\Models;
 
use Illuminate\Database\Eloquent\Casts\Attribute;
use Illuminate\Database\Eloquent\Model;
 
class User extends Model
{
    protected function myname(): Attribute
    {
        return new Attribute(
            get: fn () => 'some value'
        );
    }
}

And than, somewhere in your application call this

dd($user->isRelation('myname')); // returns TRUE

Since 'myname' is not a relation, but a Accessor, it is expected that isRelation() should return false.

A possible fix would be to do an extra check in the isRelation() method to test if a method is not a Accessor, but I'm not sure what's the best approach to do that.

[jozydapozy]

Thanks! Awesome! This fixes the issue indeed!