[12.x] Use array_first and array_last (#56706)

* wip

* fix tests

* fix tests

* add more cases

* add more cases

* head and last return false on empty array

---------

Co-authored-by: kikomanasijev <[email protected]>

Author: KIKOmanasijev

src/Illuminate/Collections/Arr.php

@@ -637,7 +637,7 @@ public static function join($array, $glue, $finalGlue = '')
         }
 
         if (count($array) === 1) {
-            return end($array);
+            return array_last($array);
         }
 
         $finalItem = array_pop($array);

src/Illuminate/Collections/helpers.php

@@ -203,7 +203,7 @@ function data_forget(&$target, $key)
      */
     function head($array)
     {
-        return reset($array);
+        return empty($array) ? false : array_first($array);
     }
 }
 
@@ -216,7 +216,7 @@ function head($array)
      */
     function last($array)
     {
-        return end($array);
+        return empty($array) ? false : array_last($array);
     }
 }
 

src/Illuminate/Console/Scheduling/Schedule.php

@@ -334,7 +334,7 @@ protected function mergePendingAttributes(Event $event)
         }
 
         if (! empty($this->groupStack)) {
-            $group = end($this->groupStack);
+            $group = array_last($this->groupStack);
 
             $group->mergeAttributes($event);
         }
@@ -476,7 +476,7 @@ public function __call($method, $parameters)
         }
 
         if (method_exists(PendingEventAttributes::class, $method)) {
-            $this->attributes ??= end($this->groupStack) ?: new PendingEventAttributes($this);
+            $this->attributes ??= array_last($this->groupStack) ?: new PendingEventAttributes($this);
 
             return $this->attributes->$method(...$parameters);
         }

src/Illuminate/Container/Container.php

@@ -1286,7 +1286,7 @@ protected function getParameterOverride($dependency)
      */
     protected function getLastParameterOverride()
     {
-        return count($this->with) ? end($this->with) : [];
+        return count($this->with) ? array_last($this->with) : [];
     }
 
     /**
@@ -1646,7 +1646,7 @@ protected function fireCallbackArray($object, array $callbacks)
      */
     public function currentlyResolving()
     {
-        return end($this->buildStack) ?: null;
+        return array_last($this->buildStack) ?: null;
     }
 
     /**

src/Illuminate/Database/Connection.php

@@ -369,7 +369,7 @@ public function scalar($query, $bindings = [], $useReadPdo = true)
             throw new MultipleColumnsSelectedException;
         }
 
-        return reset($record);
+        return array_last($record);
     }
 
     /**

src/Illuminate/Database/Eloquent/Builder.php

@@ -507,7 +507,7 @@ public function fillForInsert(array $values)
             return [];
         }
 
-        if (! is_array(reset($values))) {
+        if (! is_array(array_first($values))) {
             $values = [$values];
         }
 
@@ -1265,12 +1265,12 @@ public function upsert(array $values, $uniqueBy, $update = null)
             return 0;
         }
 
-        if (! is_array(reset($values))) {
+        if (! is_array(array_first($values))) {
             $values = [$values];
         }
 
         if (is_null($update)) {
-            $update = array_keys(reset($values));
+            $update = array_keys(array_first($values));
         }
 
         return $this->toBase()->upsert(
@@ -1366,7 +1366,7 @@ protected function addUpdatedAtColumn(array $values)
 
         $segments = preg_split('/\s+as\s+/i', $this->query->from);
 
-        $qualifiedColumn = end($segments).'.'.$column;
+        $qualifiedColumn = array_last($segments).'.'.$column;
 
         $values[$qualifiedColumn] = Arr::get($values, $qualifiedColumn, $values[$column]);
 

src/Illuminate/Database/Eloquent/Collection.php

@@ -240,7 +240,7 @@ public function loadMissing($relations)
             }
 
             if (is_callable($value)) {
-                $path[count($segments) - 1][end($segments)] = $value;
+                $path[count($segments) - 1][array_last($segments)] = $value;
             }
 
             $this->loadMissingRelation($this, $path);

src/Illuminate/Database/Eloquent/Relations/HasOneOrMany.php

@@ -291,7 +291,7 @@ public function updateOrCreate(array $attributes, array $values = [])
      */
     public function upsert(array $values, $uniqueBy, $update = null)
     {
-        if (! empty($values) && ! is_array(reset($values))) {
+        if (! empty($values) && ! is_array(array_first($values))) {
             $values = [$values];
         }
 
@@ -581,7 +581,7 @@ public function getForeignKeyName()
     {
         $segments = explode('.', $this->getQualifiedForeignKeyName());
 
-        return end($segments);
+        return array_last($segments);
     }
 
     /**

src/Illuminate/Database/Eloquent/Relations/MorphOneOrMany.php

@@ -116,7 +116,7 @@ protected function setForeignAttributesForCreate(Model $model)
      */
     public function upsert(array $values, $uniqueBy, $update = null)
     {
-        if (! empty($values) && ! is_array(reset($values))) {
+        if (! empty($values) && ! is_array(array_last($values))) {
             $values = [$values];
         }
 

src/Illuminate/Database/Query/Builder.php

@@ -3130,7 +3130,7 @@ public function value($column)
     {
         $result = (array) $this->first([$column]);
 
-        return count($result) > 0 ? reset($result) : null;
+        return count($result) > 0 ? array_first($result) : null;
     }
 
     /**
@@ -3142,7 +3142,7 @@ public function rawValue(string $expression, array $bindings = [])
     {
         $result = (array) $this->selectRaw($expression, $bindings)->first();
 
-        return count($result) > 0 ? reset($result) : null;
+        return count($result) > 0 ? array_first($result) : null;
     }
 
     /**
@@ -3158,7 +3158,7 @@ public function soleValue($column)
     {
         $result = (array) $this->sole([$column]);
 
-        return reset($result);
+        return array_last($result);
     }
 
     /**
@@ -3781,7 +3781,7 @@ public function insert(array $values)
             return true;
         }
 
-        if (! is_array(reset($values))) {
+        if (! is_array(array_last($values))) {
             $values = [$values];
         }
 
@@ -3818,7 +3818,7 @@ public function insertOrIgnore(array $values)
             return 0;
         }
 
-        if (! is_array(reset($values))) {
+        if (! is_array(array_last($values))) {
             $values = [$values];
         } else {
             foreach ($values as $key => $value) {
@@ -3976,7 +3976,7 @@ public function upsert(array $values, array|string $uniqueBy, ?array $update = n
             return (int) $this->insert($values);
         }
 
-        if (! is_array(reset($values))) {
+        if (! is_array(array_last($values))) {
             $values = [$values];
         } else {
             foreach ($values as $key => $value) {
@@ -3987,7 +3987,7 @@ public function upsert(array $values, array|string $uniqueBy, ?array $update = n
         }
 
         if (is_null($update)) {
-            $update = array_keys(reset($values));
+            $update = array_keys(array_last($values));
         }
 
         $this->applyBeforeQueryCallbacks();