feature: introduce short hand false syntax for component props (#48084)

Author: ryangjchandler

src/Illuminate/View/Compilers/ComponentTagCompiler.php

@@ -127,6 +127,10 @@ protected function compileOpeningTags(string $value)
                                 (\:\\\$)(\w+)
                             )
                             |
+                            (?:
+                                (![\w]+)
+                            )
+                            |
                             (?:
                                 [\w\-:.@%]+
                                 (
@@ -192,6 +196,10 @@ protected function compileSelfClosingTags(string $value)
                                 (\:\\\$)(\w+)
                             )
                             |
+                            (?:
+                                (![\w]+)
+                            )
+                            |
                             (?:
                                 [\w\-:.@%]+
                                 (
@@ -582,6 +590,7 @@ public function compileSlots(string $value)
     protected function getAttributesFromAttributeString(string $attributeString)
     {
         $attributeString = $this->parseShortAttributeSyntax($attributeString);
+        $attributeString = $this->parseShortFalseSyntax($attributeString);
         $attributeString = $this->parseAttributeBag($attributeString);
         $attributeString = $this->parseComponentTagClassStatements($attributeString);
         $attributeString = $this->parseComponentTagStyleStatements($attributeString);
@@ -650,6 +659,21 @@ protected function parseShortAttributeSyntax(string $value)
         }, $value);
     }
 
+    /**
+     * Parses a short false syntax like !required into a fully-qualified syntax like :required="false".
+     *
+     * @param  string  $value
+     * @return string
+     */
+    protected function parseShortFalseSyntax(string $value)
+    {
+        $pattern = "/\s!(\w+)/x";
+
+        return preg_replace_callback($pattern, function (array $matches) {
+            return " :{$matches[1]}=\"false\"";
+        }, $value);
+    }
+
     /**
      * Parse the attribute bag in a given attribute string into its fully-qualified syntax.
      *

tests/View/Blade/BladeComponentTagCompilerTest.php

@@ -734,6 +734,31 @@ public function testAttributesTreatedAsPropsAreRemovedFromFinalAttributes()
         $this->assertSame($attributes->get('other'), 'ok');
     }
 
+    public function testFalseShortSyntax()
+    {
+        $this->mockViewFactory();
+        $result = $this->compiler(['bool' => TestBoolComponent::class])->compileTags('<x-bool !bool></x-bool>');
+
+        $this->assertSame("##BEGIN-COMPONENT-CLASS##@component('Illuminate\Tests\View\Blade\TestBoolComponent', 'bool', ['bool' => false])
+<?php if (isset(\$attributes) && \$attributes instanceof Illuminate\View\ComponentAttributeBag && \$constructor = (new ReflectionClass(Illuminate\Tests\View\Blade\TestBoolComponent::class))->getConstructor()): ?>
+<?php \$attributes = \$attributes->except(collect(\$constructor->getParameters())->map->getName()->all()); ?>
+<?php endif; ?>
+<?php \$component->withAttributes([]); ?> @endComponentClass##END-COMPONENT-CLASS##", trim($result));
+    }
+
+    public function testSelfClosingComponentWithFalseShortSyntax()
+    {
+        $this->mockViewFactory();
+        $result = $this->compiler(['bool' => TestBoolComponent::class])->compileTags('<x-bool !bool />');
+
+        $this->assertSame("##BEGIN-COMPONENT-CLASS##@component('Illuminate\Tests\View\Blade\TestBoolComponent', 'bool', ['bool' => false])
+<?php if (isset(\$attributes) && \$attributes instanceof Illuminate\View\ComponentAttributeBag && \$constructor = (new ReflectionClass(Illuminate\Tests\View\Blade\TestBoolComponent::class))->getConstructor()): ?>
+<?php \$attributes = \$attributes->except(collect(\$constructor->getParameters())->map->getName()->all()); ?>
+<?php endif; ?>
+<?php \$component->withAttributes([]); ?>
+@endComponentClass##END-COMPONENT-CLASS##", trim($result));
+    }
+
     protected function mockViewFactory($existsSucceeds = true)
     {
         $container = new Container;
@@ -797,3 +822,18 @@ public function render()
         return 'input';
     }
 }
+
+class TestBoolComponent extends Component
+{
+    public $bool;
+
+    public function __construct($bool)
+    {
+        $this->bool = $bool;
+    }
+
+    public function render()
+    {
+        return 'bool';
+    }
+}