[10.x] Remove autoload dumping from make:migration (#46215)

* Removes composer autoload generation from make:migration commands

* wip

* wip

* Deprecates composer property

Author: timacdonald

src/Illuminate/Cache/Console/CacheTableCommand.php

@@ -33,6 +33,8 @@ class CacheTableCommand extends Command
 
     /**
      * @var \Illuminate\Support\Composer
+     *
+     * @deprecated Will be removed in a future Laravel version.
      */
     protected $composer;
 
@@ -63,8 +65,6 @@ public function handle()
         $this->files->put($fullPath, $this->files->get(__DIR__.'/stubs/cache.stub'));
 
         $this->components->info('Migration created successfully.');
-
-        $this->composer->dumpAutoloads();
     }
 
     /**

src/Illuminate/Database/Console/Migrations/MigrateMakeCommand.php

@@ -39,6 +39,8 @@ class MigrateMakeCommand extends BaseCommand implements PromptsForMissingInput
      * The Composer instance.
      *
      * @var \Illuminate\Support\Composer
+     *
+     * @deprecated Will be removed in a future Laravel version.
      */
     protected $composer;
 
@@ -93,8 +95,6 @@ public function handle()
         // the migration out, we will dump-autoload for the entire framework to
         // make sure that the migrations are registered by the class loaders.
         $this->writeMigration($name, $table, $create);
-
-        $this->composer->dumpAutoloads();
     }
 
     /**

src/Illuminate/Notifications/Console/NotificationTableCommand.php

@@ -33,6 +33,8 @@ class NotificationTableCommand extends Command
 
     /**
      * @var \Illuminate\Support\Composer
+     *
+     * @deprecated Will be removed in a future Laravel version.
      */
     protected $composer;
 
@@ -63,8 +65,6 @@ public function handle()
         $this->files->put($fullPath, $this->files->get(__DIR__.'/stubs/notifications.stub'));
 
         $this->components->info('Migration created successfully.');
-
-        $this->composer->dumpAutoloads();
     }
 
     /**

src/Illuminate/Queue/Console/BatchesTableCommand.php

@@ -33,6 +33,8 @@ class BatchesTableCommand extends Command
 
     /**
      * @var \Illuminate\Support\Composer
+     *
+     * @deprecated Will be removed in a future Laravel version.
      */
     protected $composer;
 
@@ -65,8 +67,6 @@ public function handle()
         );
 
         $this->components->info('Migration created successfully.');
-
-        $this->composer->dumpAutoloads();
     }
 
     /**

src/Illuminate/Queue/Console/FailedTableCommand.php

@@ -33,6 +33,8 @@ class FailedTableCommand extends Command
 
     /**
      * @var \Illuminate\Support\Composer
+     *
+     * @deprecated Will be removed in a future Laravel version.
      */
     protected $composer;
 
@@ -65,8 +67,6 @@ public function handle()
         );
 
         $this->components->info('Migration created successfully.');
-
-        $this->composer->dumpAutoloads();
     }
 
     /**

src/Illuminate/Queue/Console/TableCommand.php

@@ -33,6 +33,8 @@ class TableCommand extends Command
 
     /**
      * @var \Illuminate\Support\Composer
+     *
+     * @deprecated Will be removed in a future Laravel version.
      */
     protected $composer;
 
@@ -65,8 +67,6 @@ public function handle()
         );
 
         $this->components->info('Migration created successfully.');
-
-        $this->composer->dumpAutoloads();
     }
 
     /**

src/Illuminate/Session/Console/SessionTableCommand.php

@@ -33,6 +33,8 @@ class SessionTableCommand extends Command
 
     /**
      * @var \Illuminate\Support\Composer
+     *
+     * @deprecated Will be removed in a future Laravel version.
      */
     protected $composer;
 
@@ -63,8 +65,6 @@ public function handle()
         $this->files->put($fullPath, $this->files->get(__DIR__.'/stubs/database.stub'));
 
         $this->components->info('Migration created successfully.');
-
-        $this->composer->dumpAutoloads();
     }
 
     /**

tests/Cache/CacheTableCommandTest.php

@@ -35,7 +35,6 @@ public function testCreateMakesMigration()
         $creator->shouldReceive('create')->once()->with('create_cache_table', $path)->andReturn($path);
         $files->shouldReceive('get')->once()->andReturn('foo');
         $files->shouldReceive('put')->once()->with($path, 'foo');
-        $composer->shouldReceive('dumpAutoloads')->once();
 
         $this->runCommand($command);
     }

tests/Database/DatabaseMigrationMakeCommandTest.php

@@ -30,7 +30,6 @@ public function testBasicCreateDumpsAutoload()
         $creator->shouldReceive('create')->once()
                 ->with('create_foo', __DIR__.DIRECTORY_SEPARATOR.'migrations', 'foo', true)
                 ->andReturn(__DIR__.'/migrations/2021_04_23_110457_create_foo.php');
-        $composer->shouldReceive('dumpAutoloads')->once();
 
         $this->runCommand($command, ['name' => 'create_foo']);
     }

tests/Session/SessionTableCommandTest.php

@@ -35,7 +35,6 @@ public function testCreateMakesMigration()
         $creator->shouldReceive('create')->once()->with('create_sessions_table', $path)->andReturn($path);
         $files->shouldReceive('get')->once()->andReturn('foo');
         $files->shouldReceive('put')->once()->with($path, 'foo');
-        $composer->shouldReceive('dumpAutoloads')->once();
 
         $this->runCommand($command);
     }