Fix CallToolWithExecutor Error (#359)

* Fix ResponseFactory::map() method not found error in CallToolWithExecutor

- Call ->responses() first to get Collection before using ->map() and ->contains()
- Fixes BadMethodCallException when executing MCP tools
- Resolves issue where ResponseFactory was being treated as a Collection

* Revert "Fix ResponseFactory::map() method not found error in CallToolWithExecutor"

This reverts commit 8d5360e.

* Fix ResponseFactory::map() method not found error in CallToolWithExecutor

- Call ->responses() first to get Collection before using ->map() and ->contains()
- Fixes BadMethodCallException when executing MCP tools
- Resolves issue where ResponseFactory was being treated as a Collection

* Add comprehensive tests for CallToolWithExecutor fix

- Add 5 test cases covering ResponseFactory fix
- Tests verify ->responses()->map() works correctly
- Tests cover error handling and validation
- Add PR description document

* Remove PR description file from repository

* Remove Unnecessary Test

Signed-off-by: Pushpak Chhajed <[email protected]>

* Bump minimum mcp package

Signed-off-by: Pushpak Chhajed <[email protected]>

---------

Signed-off-by: Pushpak Chhajed <[email protected]>
Co-authored-by: Pushpak Chhajed <[email protected]>

Author: RedArchon

composer.json

@@ -19,7 +19,7 @@
         "illuminate/contracts": "^10.49.0|^11.45.3|^12.28.1",
         "illuminate/routing": "^10.49.0|^11.45.3|^12.28.1",
         "illuminate/support": "^10.49.0|^11.45.3|^12.28.1",
-        "laravel/mcp": "^0.3.2",
+        "laravel/mcp": "^0.3.4",
         "laravel/prompts": "0.1.25|^0.3.6",
         "laravel/roster": "^0.2.9"
     },

src/Mcp/Methods/CallToolWithExecutor.php

@@ -58,9 +58,9 @@ public function handle(JsonRpcRequest $request, ServerContext $context): JsonRpc
             $response = Response::error('Tool execution error: '.$throwable->getMessage());
         }
 
-        return $this->toJsonRpcResponse($request, $response, fn ($responses): array => [
-            'content' => $responses->map(fn ($response) => $response->content()->toTool($tool))->all(),
-            'isError' => $responses->contains(fn ($response) => $response->isError()),
+        return $this->toJsonRpcResponse($request, $response, fn ($responseFactory): array => [
+            'content' => $responseFactory->responses()->map(fn ($response) => $response->content()->toTool($tool))->all(),
+            'isError' => $responseFactory->responses()->contains(fn ($response) => $response->isError()),
         ]);
     }
 }