Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asserts on size_t >= 0 #83

Open
jacob-moore22 opened this issue May 9, 2024 · 0 comments
Open

Asserts on size_t >= 0 #83

jacob-moore22 opened this issue May 9, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@jacob-moore22
Copy link
Collaborator

Our asserts need to be tweaked. With a verbose compiler I'm getting the following warning for most all of the asserts:

"<path>/kokkos_types.h", line 3834: warning: pointless comparison of unsigned integer with zero [unsigned_compare_with_zero]
      assert(j >= 0 && j < dims_[1] && "j is out of bounds in ViewCArrayKokkos 2D!");

Its a valid point, since j is a size_t, it is impossible for it to be anything other than >=0.

@jacob-moore22 jacob-moore22 added the good first issue Good for newcomers label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant