From 1e9178c7c4873a8adc4ec72f974cdc309f7f83b7 Mon Sep 17 00:00:00 2001 From: Gabriel Luiz Freitas Almeida Date: Wed, 28 Aug 2024 18:10:54 -0300 Subject: [PATCH 1/2] style: fix E721 --- src/backend/base/langflow/custom/utils.py | 4 ++-- src/backend/base/langflow/helpers/custom.py | 2 +- src/backend/base/langflow/services/settings/base.py | 4 ++-- src/backend/base/langflow/template/field/base.py | 2 +- src/backend/tests/unit/io/test_io_schema.py | 6 +++--- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/backend/base/langflow/custom/utils.py b/src/backend/base/langflow/custom/utils.py index cd235a66dcc3..10ee795c29a9 100644 --- a/src/backend/base/langflow/custom/utils.py +++ b/src/backend/base/langflow/custom/utils.py @@ -44,7 +44,7 @@ def add_output_types(frontend_node: CustomComponentFrontendNode, return_types: l "traceback": traceback.format_exc(), }, ) - if return_type == str: + if return_type is str: return_type = "Text" elif hasattr(return_type, "__name__"): return_type = return_type.__name__ @@ -85,7 +85,7 @@ def add_base_classes(frontend_node: CustomComponentFrontendNode, return_types: l ) base_classes = get_base_classes(return_type_instance) - if return_type_instance == str: + if return_type_instance is str: base_classes.append("Text") for base_class in base_classes: diff --git a/src/backend/base/langflow/helpers/custom.py b/src/backend/base/langflow/helpers/custom.py index bdbb128f4c2a..225c124dcfb4 100644 --- a/src/backend/base/langflow/helpers/custom.py +++ b/src/backend/base/langflow/helpers/custom.py @@ -2,7 +2,7 @@ def format_type(type_: Any) -> str: - if type_ == str: + if type_ is str: type_ = "Text" elif hasattr(type_, "__name__"): type_ = type_.__name__ diff --git a/src/backend/base/langflow/services/settings/base.py b/src/backend/base/langflow/services/settings/base.py index bb775992cfb7..c3e15fe58d8a 100644 --- a/src/backend/base/langflow/services/settings/base.py +++ b/src/backend/base/langflow/services/settings/base.py @@ -36,8 +36,8 @@ def is_list_of_any(field: FieldInfo) -> bool: else: union_args = [] - return field.annotation.__origin__ == list or any( - arg.__origin__ == list for arg in union_args if hasattr(arg, "__origin__") + return field.annotation.__origin__ is list or any( + arg.__origin__ is list for arg in union_args if hasattr(arg, "__origin__") ) except AttributeError: return False diff --git a/src/backend/base/langflow/template/field/base.py b/src/backend/base/langflow/template/field/base.py index 6cc2eadb8176..5686dcfe8c23 100644 --- a/src/backend/base/langflow/template/field/base.py +++ b/src/backend/base/langflow/template/field/base.py @@ -119,7 +119,7 @@ def serialize_file_path(self, value): @field_serializer("field_type") def serialize_field_type(self, value, _info): - if value == float and self.range_spec is None: + if value is float and self.range_spec is None: self.range_spec = RangeSpec() return value diff --git a/src/backend/tests/unit/io/test_io_schema.py b/src/backend/tests/unit/io/test_io_schema.py index 2c0a4f72d2b0..7dad32e75655 100644 --- a/src/backend/tests/unit/io/test_io_schema.py +++ b/src/backend/tests/unit/io/test_io_schema.py @@ -116,7 +116,7 @@ def test_non_standard_field_types_handling(self): input_instance = FileInput(name="file_field") schema = create_input_schema([input_instance]) field_info = schema.model_fields["file_field"] - assert field_info.annotation == str + assert field_info.annotation is str # Inputs with mixed required and optional fields are processed correctly def test_mixed_required_optional_fields_processing(self): @@ -184,7 +184,7 @@ def test_is_list_handling(self): input_instance = StrInput(name="test_field", is_list=True) schema = create_input_schema([input_instance]) field_info = schema.model_fields["test_field"] - assert field_info.annotation == list[str] + assert field_info.annotation is list[str] # Converting FieldTypes to corresponding Python types def test_field_types_conversion(self): @@ -194,7 +194,7 @@ def test_field_types_conversion(self): input_instance = IntInput(name="int_field") schema = create_input_schema([input_instance]) field_info = schema.model_fields["int_field"] - assert field_info.annotation == int + assert field_info.annotation is int # Use 'is' for type comparison # Setting default values for non-required fields def test_default_values_for_non_required_fields(self): From 3c0c2b827a32dbcbe7d0e84e94bb7f77e0e0f35e Mon Sep 17 00:00:00 2001 From: Gabriel Luiz Freitas Almeida Date: Thu, 29 Aug 2024 08:39:54 -0300 Subject: [PATCH 2/2] Fix type comparison in test_io_schema.py by using '==' instead of 'is' --- src/backend/tests/unit/io/test_io_schema.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/tests/unit/io/test_io_schema.py b/src/backend/tests/unit/io/test_io_schema.py index 7dad32e75655..0a518ce43d94 100644 --- a/src/backend/tests/unit/io/test_io_schema.py +++ b/src/backend/tests/unit/io/test_io_schema.py @@ -184,7 +184,7 @@ def test_is_list_handling(self): input_instance = StrInput(name="test_field", is_list=True) schema = create_input_schema([input_instance]) field_info = schema.model_fields["test_field"] - assert field_info.annotation is list[str] + assert field_info.annotation == list[str] # type: ignore # Converting FieldTypes to corresponding Python types def test_field_types_conversion(self):