Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out-of-date Component Code detection is intermittent #5179

Closed
mieslep opened this issue Dec 10, 2024 · 1 comment
Closed

Out-of-date Component Code detection is intermittent #5179

mieslep opened this issue Dec 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mieslep
Copy link
Contributor

mieslep commented Dec 10, 2024

Bug Description

I believe this mostly affects component developers, but not 100% it doesn't affect others. Once a component has been detected as out-of-date and the "Update Component" button is clicked, the component no longer shows as being out-of-date if changes are made, even after restarting services.

Reproduction

  1. Start a development server (make backend and make frontend)
  2. Bring a component onto the canvas
  3. Modify that component on the source code; the backend service will restart.
  4. Refresh the browser; the component will show it needs to be updated.
  5. Update the component via the UI.
  6. Make another modification to the component; the backend service will restart
  7. Refresh the browser: the component does not show it needs to be updated.

Expected behavior

The component should show it needs to be updated.

Who can help?

No response

Operating System

devcontainer

Langflow Version

1.1.1.devX

Python Version

3.12

Screenshot

No response

Flow File

No response

@mieslep mieslep added the bug Something isn't working label Dec 10, 2024
@Cristhianzl
Copy link
Member

hi @mieslep how are you?

I was analyzing your case and noticed that this error occurs when a component's name is changed.
Example: when name = "ChatInput" is changed to name = "ChatInputNew"

When this happens, we lose the component reference and can no longer update or check if it's outdated because it's interpreted as a component from outside Langflow.
To prevent this error, we ask that you only modify the display_name variable. This way, we can detect any code changes and notify users when an update is needed.

Thank you for the feedback.
Please let me know if this works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants