From 4cd8f012ece79234bfb52bc177f40c3c5bf2184e Mon Sep 17 00:00:00 2001 From: Predrag Gruevski Date: Tue, 31 Oct 2023 15:57:16 +0000 Subject: [PATCH 1/3] Show ruff output inline in GitHub PRs. --- .github/workflows/_lint.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/_lint.yml b/.github/workflows/_lint.yml index 19560f20d0612..a1a3e17bfbfb1 100644 --- a/.github/workflows/_lint.yml +++ b/.github/workflows/_lint.yml @@ -16,6 +16,9 @@ env: POETRY_VERSION: "1.6.1" WORKDIR: ${{ inputs.working-directory == '' && '.' || inputs.working-directory }} + # This env var allows us to get inline annotations when ruff has complaints. + RUFF_OUTPUT_FORMAT: github + jobs: build: runs-on: ubuntu-latest From 1ee6f885bbe22c617046f6923b370ef7cd35e793 Mon Sep 17 00:00:00 2001 From: Predrag Gruevski Date: Tue, 31 Oct 2023 15:58:58 +0000 Subject: [PATCH 2/3] Intentionally cause ruff errors to check env var works. --- libs/langchain/langchain/utils/aiter.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libs/langchain/langchain/utils/aiter.py b/libs/langchain/langchain/utils/aiter.py index ca44dee3958d3..fc292820719e6 100644 --- a/libs/langchain/langchain/utils/aiter.py +++ b/libs/langchain/langchain/utils/aiter.py @@ -43,8 +43,7 @@ def py_anext( """ try: - __anext__ = cast( - Callable[[AsyncIterator[T]], Awaitable[T]], type(iterator).__anext__ + __anext__ = cast(Callable[[AsyncIterator[T]], Awaitable[T]], type(iterator).__anext__ ) except AttributeError: raise TypeError(f"{iterator!r} is not an async iterator") From eaf696e6db2f9b74d1cc86035f54e86ab3472b21 Mon Sep 17 00:00:00 2001 From: Predrag Gruevski Date: Tue, 31 Oct 2023 16:03:47 +0000 Subject: [PATCH 3/3] Revert "Intentionally cause ruff errors to check env var works." This reverts commit 1ee6f885bbe22c617046f6923b370ef7cd35e793. --- libs/langchain/langchain/utils/aiter.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/langchain/langchain/utils/aiter.py b/libs/langchain/langchain/utils/aiter.py index fc292820719e6..ca44dee3958d3 100644 --- a/libs/langchain/langchain/utils/aiter.py +++ b/libs/langchain/langchain/utils/aiter.py @@ -43,7 +43,8 @@ def py_anext( """ try: - __anext__ = cast(Callable[[AsyncIterator[T]], Awaitable[T]], type(iterator).__anext__ + __anext__ = cast( + Callable[[AsyncIterator[T]], Awaitable[T]], type(iterator).__anext__ ) except AttributeError: raise TypeError(f"{iterator!r} is not an async iterator")