multiple: combine sync/async vector store standard test suites (#28580)

Breaking change in `langchain-tests`.

docs/docs/contributing/how_to/integrations/standard_tests.ipynb

@@ -505,36 +505,21 @@
    "source": [
     "# title=\"tests/integration_tests/test_vectorstores_sync.py\"\n",
     "\n",
-    "from typing import AsyncGenerator, Generator\n",
+    "from typing import Generator\n",
     "\n",
     "import pytest\n",
     "from langchain_core.vectorstores import VectorStore\n",
     "from langchain_parrot_link.vectorstores import ParrotVectorStore\n",
     "from langchain_standard_tests.integration_tests.vectorstores import (\n",
-    "    AsyncReadWriteTestSuite,\n",
-    "    ReadWriteTestSuite,\n",
+    "    VectorStoreIntegrationTests,\n",
     ")\n",
     "\n",
     "\n",
-    "class TestSync(ReadWriteTestSuite):\n",
+    "class TestParrotVectorStore(VectorStoreIntegrationTests):\n",
     "    @pytest.fixture()\n",
     "    def vectorstore(self) -> Generator[VectorStore, None, None]:  # type: ignore\n",
     "        \"\"\"Get an empty vectorstore for unit tests.\"\"\"\n",
-    "        store = ParrotVectorStore()\n",
-    "        # note: store should be EMPTY at this point\n",
-    "        # if you need to delete data, you may do so here\n",
-    "        try:\n",
-    "            yield store\n",
-    "        finally:\n",
-    "            # cleanup operations, or deleting data\n",
-    "            pass\n",
-    "\n",
-    "\n",
-    "class TestAsync(AsyncReadWriteTestSuite):\n",
-    "    @pytest.fixture()\n",
-    "    async def vectorstore(self) -> AsyncGenerator[VectorStore, None]:  # type: ignore\n",
-    "        \"\"\"Get an empty vectorstore for unit tests.\"\"\"\n",
-    "        store = ParrotVectorStore()\n",
+    "        store = ParrotVectorStore(self.get_embeddings())\n",
     "        # note: store should be EMPTY at this point\n",
     "        # if you need to delete data, you may do so here\n",
     "        try:\n",
@@ -548,38 +533,38 @@
    "cell_type": "markdown",
    "metadata": {},
    "source": [
-    "There are separate suites for testing synchronous and asynchronous methods.\n",
     "Configuring the tests consists of implementing pytest fixtures for setting up an\n",
     "empty vector store and tearing down the vector store after the test run ends.\n",
     "\n",
-    "For example, below is the `ReadWriteTestSuite` for the [Chroma](https://python.langchain.com/docs/integrations/vectorstores/chroma/)\n",
+    "For example, below is the `VectorStoreIntegrationTests` class for the [Chroma](https://python.langchain.com/docs/integrations/vectorstores/chroma/)\n",
     "integration:\n",
     "\n",
     "```python\n",
     "from typing import Generator\n",
     "\n",
     "import pytest\n",
     "from langchain_core.vectorstores import VectorStore\n",
-    "from langchain_tests.integration_tests.vectorstores import ReadWriteTestSuite\n",
+    "from langchain_tests.integration_tests.vectorstores import VectorStoreIntegrationTests\n",
     "\n",
     "from langchain_chroma import Chroma\n",
     "\n",
     "\n",
-    "class TestSync(ReadWriteTestSuite):\n",
+    "class TestChromaStandard(VectorStoreIntegrationTests):\n",
     "    @pytest.fixture()\n",
     "    def vectorstore(self) -> Generator[VectorStore, None, None]:  # type: ignore\n",
-    "        \"\"\"Get an empty vectorstore.\"\"\"\n",
+    "        \"\"\"Get an empty vectorstore for unit tests.\"\"\"\n",
     "        store = Chroma(embedding_function=self.get_embeddings())\n",
     "        try:\n",
     "            yield store\n",
     "        finally:\n",
     "            store.delete_collection()\n",
     "            pass\n",
+    "\n",
     "```\n",
     "\n",
     "Note that before the initial `yield`, we instantiate the vector store with an\n",
     "[embeddings](/docs/concepts/embedding_models/) object. This is a pre-defined\n",
-    "[\"fake\" embeddings model](https://python.langchain.com/api_reference/standard_tests/integration_tests/langchain_tests.integration_tests.vectorstores.ReadWriteTestSuite.html#langchain_tests.integration_tests.vectorstores.ReadWriteTestSuite.get_embeddings)\n",
+    "[\"fake\" embeddings model](https://python.langchain.com/api_reference/standard_tests/integration_tests/langchain_tests.integration_tests.vectorstores.VectorStoreIntegrationTests.html#langchain_tests.integration_tests.vectorstores.VectorStoreIntegrationTests.get_embeddings)\n",
     "that will generate short, arbitrary vectors for documents. You can use a different\n",
     "embeddings object if desired.\n",
     "\n",
@@ -589,10 +574,7 @@
     "\n",
     ":::note\n",
     "\n",
-    "Details on what tests are run, how each test can be skipped, and troubleshooting tips for each test can be found in the API references. See details:\n",
-    "\n",
-    "- [Sync tests API reference](https://python.langchain.com/api_reference/standard_tests/integration_tests/langchain_tests.integration_tests.vectorstores.ReadWriteTestSuite.html)\n",
-    "- [Async tests API reference](https://python.langchain.com/api_reference/standard_tests/integration_tests/langchain_tests.integration_tests.vectorstores.AsyncReadWriteTestSuite.html)\n",
+    "Details on what tests are run and troubleshooting tips for each test can be found in the [API reference](https://python.langchain.com/api_reference/standard_tests/integration_tests/langchain_tests.integration_tests.vectorstores.VectorStoreIntegrationTests.html).\n",
     "\n",
     ":::"
    ]

libs/cli/langchain_cli/integration_template/tests/integration_tests/test_vectorstores.py

@@ -1,15 +1,12 @@
-from typing import AsyncGenerator, Generator
+from typing import Generator
 
 import pytest
 from __module_name__.vectorstores import __ModuleName__VectorStore
 from langchain_core.vectorstores import VectorStore
-from langchain_tests.integration_tests import (
-    AsyncReadWriteTestSuite,
-    ReadWriteTestSuite,
-)
+from langchain_tests.integration_tests import VectorStoreIntegrationTests
 
 
-class Test__ModuleName__VectorStoreSync(ReadWriteTestSuite):
+class Test__ModuleName__VectorStore(VectorStoreIntegrationTests):
     @pytest.fixture()
     def vectorstore(self) -> Generator[VectorStore, None, None]:  # type: ignore
         """Get an empty vectorstore for unit tests."""
@@ -21,17 +18,3 @@ def vectorstore(self) -> Generator[VectorStore, None, None]:  # type: ignore
         finally:
             # cleanup operations, or deleting data
             pass
-
-
-class Test__ModuleName__VectorStoreAsync(AsyncReadWriteTestSuite):
-    @pytest.fixture()
-    async def vectorstore(self) -> AsyncGenerator[VectorStore, None]:  # type: ignore
-        """Get an empty vectorstore for unit tests."""
-        store = __ModuleName__VectorStore(self.get_embeddings())
-        # note: store should be EMPTY at this point
-        # if you need to delete data, you may do so here
-        try:
-            yield store
-        finally:
-            # cleanup operations, or deleting data
-            pass

libs/community/tests/integration_tests/vectorstores/test_aperturedb.py

@@ -3,27 +3,15 @@
 import uuid
 
 import pytest
-from langchain_tests.integration_tests.vectorstores import (
-    AsyncReadWriteTestSuite,
-    ReadWriteTestSuite,
-)
+from langchain_tests.integration_tests.vectorstores import VectorStoreIntegrationTests
 
 from langchain_community.vectorstores import ApertureDB
 
 
-class TestApertureDBReadWriteTestSuite(ReadWriteTestSuite):
+class TestApertureStandard(VectorStoreIntegrationTests):
     @pytest.fixture
     def vectorstore(self) -> ApertureDB:
         descriptor_set = uuid.uuid4().hex  # Fresh descriptor set for each test
         return ApertureDB(
             embeddings=self.get_embeddings(), descriptor_set=descriptor_set
         )
-
-
-class TestAsyncApertureDBReadWriteTestSuite(AsyncReadWriteTestSuite):
-    @pytest.fixture
-    async def vectorstore(self) -> ApertureDB:
-        descriptor_set = uuid.uuid4().hex  # Fresh descriptor set for each test
-        return ApertureDB(
-            embeddings=self.get_embeddings(), descriptor_set=descriptor_set
-        )

libs/community/tests/unit_tests/vectorstores/test_inmemory.py

@@ -3,10 +3,7 @@
 
 import pytest
 from langchain_core.documents import Document
-from langchain_tests.integration_tests.vectorstores import (
-    AsyncReadWriteTestSuite,
-    ReadWriteTestSuite,
-)
+from langchain_tests.integration_tests.vectorstores import VectorStoreIntegrationTests
 
 from langchain_community.vectorstores.inmemory import InMemoryVectorStore
 from tests.integration_tests.vectorstores.fake_embeddings import (
@@ -26,18 +23,12 @@ def _AnyDocument(**kwargs: Any) -> Document:
     return doc
 
 
-class TestInMemoryReadWriteTestSuite(ReadWriteTestSuite):
+class TestInMemoryStandard(VectorStoreIntegrationTests):
     @pytest.fixture
     def vectorstore(self) -> InMemoryVectorStore:
         return InMemoryVectorStore(embedding=self.get_embeddings())
 
 
-class TestAsyncInMemoryReadWriteTestSuite(AsyncReadWriteTestSuite):
-    @pytest.fixture
-    async def vectorstore(self) -> InMemoryVectorStore:
-        return InMemoryVectorStore(embedding=self.get_embeddings())
-
-
 async def test_inmemory() -> None:
     """Test end to end construction and search."""
     store = await InMemoryVectorStore.afrom_texts(

libs/core/tests/unit_tests/vectorstores/test_in_memory.py

@@ -2,29 +2,20 @@
 from unittest.mock import AsyncMock, Mock
 
 import pytest
-from langchain_tests.integration_tests.vectorstores import (
-    AsyncReadWriteTestSuite,
-    ReadWriteTestSuite,
-)
+from langchain_tests.integration_tests.vectorstores import VectorStoreIntegrationTests
 
 from langchain_core.documents import Document
 from langchain_core.embeddings.fake import DeterministicFakeEmbedding
 from langchain_core.vectorstores import InMemoryVectorStore
 from tests.unit_tests.stubs import _any_id_document
 
 
-class TestInMemoryReadWriteTestSuite(ReadWriteTestSuite):
+class TestInMemoryStandard(VectorStoreIntegrationTests):
     @pytest.fixture
     def vectorstore(self) -> InMemoryVectorStore:
         return InMemoryVectorStore(embedding=self.get_embeddings())
 
 
-class TestAsyncInMemoryReadWriteTestSuite(AsyncReadWriteTestSuite):
-    @pytest.fixture
-    async def vectorstore(self) -> InMemoryVectorStore:
-        return InMemoryVectorStore(embedding=self.get_embeddings())
-
-
 async def test_inmemory_similarity_search() -> None:
     """Test end to end similarity search."""
     store = await InMemoryVectorStore.afrom_texts(

libs/partners/chroma/tests/integration_tests/test_standard.py

@@ -1,16 +1,13 @@
-from typing import AsyncGenerator, Generator
+from typing import Generator
 
 import pytest
 from langchain_core.vectorstores import VectorStore
-from langchain_tests.integration_tests.vectorstores import (
-    AsyncReadWriteTestSuite,
-    ReadWriteTestSuite,
-)
+from langchain_tests.integration_tests.vectorstores import VectorStoreIntegrationTests
 
 from langchain_chroma import Chroma
 
 
-class TestSync(ReadWriteTestSuite):
+class TestChromaStandard(VectorStoreIntegrationTests):
     @pytest.fixture()
     def vectorstore(self) -> Generator[VectorStore, None, None]:  # type: ignore
         """Get an empty vectorstore for unit tests."""
@@ -20,15 +17,3 @@ def vectorstore(self) -> Generator[VectorStore, None, None]:  # type: ignore
         finally:
             store.delete_collection()
             pass
-
-
-class TestAsync(AsyncReadWriteTestSuite):
-    @pytest.fixture()
-    async def vectorstore(self) -> AsyncGenerator[VectorStore, None]:  # type: ignore
-        """Get an empty vectorstore for unit tests."""
-        store = Chroma(embedding_function=self.get_embeddings())
-        try:
-            yield store
-        finally:
-            store.delete_collection()
-            pass

libs/standard-tests/langchain_tests/integration_tests/__init__.py

@@ -23,7 +23,7 @@
 from .embeddings import EmbeddingsIntegrationTests
 from .retrievers import RetrieversIntegrationTests
 from .tools import ToolsIntegrationTests
-from .vectorstores import AsyncReadWriteTestSuite, ReadWriteTestSuite
+from .vectorstores import VectorStoreIntegrationTests
 
 __all__ = [
     "ChatModelIntegrationTests",
@@ -33,7 +33,6 @@
     "BaseStoreSyncTests",
     "AsyncCacheTestSuite",
     "SyncCacheTestSuite",
-    "AsyncReadWriteTestSuite",
-    "ReadWriteTestSuite",
+    "VectorStoreIntegrationTests",
     "RetrieversIntegrationTests",
 ]