From 12f7392b459abb7f373aeb52b96e3e22c0700dcc Mon Sep 17 00:00:00 2001 From: ben11211 Date: Mon, 27 Jul 2026 16:27:27 -0700 Subject: [PATCH] fix(langsmith): configure plaintext OTLP exporters Set the standard OpenTelemetry insecure flag from useTls so Python exporters connect correctly to plaintext collectors while preserving TLS behavior. Co-authored-by: Cursor --- charts/langsmith/templates/config-map.yaml | 1 + .../tests/langsmith_smithdb_test.yaml | 20 +++++++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/charts/langsmith/templates/config-map.yaml b/charts/langsmith/templates/config-map.yaml index 1e217cf2f..416ddcbaf 100644 --- a/charts/langsmith/templates/config-map.yaml +++ b/charts/langsmith/templates/config-map.yaml @@ -90,6 +90,7 @@ data: OTEL_ENVIRONMENT: "{{ .Values.config.observability.tracing.env }}" OTEL_EXPORTER: "{{ .Values.config.observability.tracing.exporter }}" OTEL_USE_TLS: "{{ .Values.config.observability.tracing.useTls }}" + OTEL_EXPORTER_OTLP_INSECURE: {{ (not .Values.config.observability.tracing.useTls) | quote }} {{- else }} OTEL_TRACING_ENABLED: "false" OTLP_ENDPOINT: "" diff --git a/charts/langsmith/tests/langsmith_smithdb_test.yaml b/charts/langsmith/tests/langsmith_smithdb_test.yaml index b50cbb4cb..79db242e4 100644 --- a/charts/langsmith/tests/langsmith_smithdb_test.yaml +++ b/charts/langsmith/tests/langsmith_smithdb_test.yaml @@ -158,6 +158,26 @@ tests: - equal: path: data.OTLP_ENDPOINT value: default-otel-collector:4317 + - equal: + path: data.OTEL_EXPORTER_OTLP_INSECURE + value: "true" + + - it: should configure secure OTLP transport for LangSmith services + values: + - ./values/smithdb-enabled.yaml + set: + config.observability.tracing.enabled: true + config.observability.tracing.endpoint: secure-otel-collector:4317 + config.observability.tracing.useTls: true + config.observability.tracing.exporter: grpc + template: config-map.yaml + asserts: + - equal: + path: data.OTLP_ENDPOINT + value: secure-otel-collector:4317 + - equal: + path: data.OTEL_EXPORTER_OTLP_INSECURE + value: "false" - it: should derive the TLS SmithDB OTLP endpoint from chart-level tracing values: