Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right scrolling of an image bug! #471

Closed
arduino12 opened this issue Sep 28, 2020 · 2 comments
Closed

Fix right scrolling of an image bug! #471

arduino12 opened this issue Sep 28, 2020 · 2 comments

Comments

@arduino12
Copy link

Hi,

I want to be able to scroll an image from left to right,
But apparently- it only works in the web simulator- see my demo of the bug here.

I found that the cause of this is here.

To my thinking - the quick-fix will be to rename image.shiftLeft(int16_t n) into image.shiftHorizontal(int offset) -
So it can accept a negative value and shift the image to the right as well.

But a better fix will be to rename it into shift(enum direction) or shift(int x_offset, int y_offset) -
So we can shift an image in all directions!

Thanks!

@martinwork
Copy link
Contributor

How about this? #427

@arduino12
Copy link
Author

Oh sorry I missed your PR @martinwork - it could solve my issue !

But sadly it seems that nobody here want's to merge it after reading the issue #351 from 2018 :(

Shame that people had to re-implemet this in the higher layer like this.

My goal is to add Hebrew font for my students - I wanted to do it in this DAL lower layer -
But it looks like I better do it myself in the .ts files so I don't have to wait 1+ years for a PR approvers.
Anyway I will close this issue now and will write my scrolling code using the .ts files. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants