Add scala.quoted.Liftables to the stdlib
#6928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
changed the title
quoted.Liftable[List[T]] to the stdlib
nicolasstucki
changed the title
scala.quoted.Liftables to the stdlib
nicolasstucki
force-pushed
the
add-liftables-to-stdlib
branch
from
31c0f08
to
3340db1
Compare
liufengyun
approved these changes
Jul 26, 2019
| given [T1: Type: Liftable] as Liftable[Tuple1[T1]] = new { | ||
| def toExpr(tup: Tuple1[T1]) = | ||
| '{ Tuple1(${tup._1.toExpr}) } | ||
| } |
There was a problem hiding this comment.
Minor: maybe still write new Liftable[...] to be consistent and explicit as above, the same for the code below
There was a problem hiding this comment.
It got way too long and made it harder to read.
nicolasstucki
force-pushed
the
add-liftables-to-stdlib
branch
from
08d9b6b
to
5796226
Compare
nicolasstucki
force-pushed
the
add-liftables-to-stdlib
branch
from
5d46185
to
36186f0
Compare
nicolasstucki
force-pushed
the
add-liftables-to-stdlib
branch
from
36186f0
to
81dd055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.