Support multi-project rename #5462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@smarter Can you take a look, please? |
smarter
approved these changes
Nov 29, 2018
When doing go-to-definition, we used to look for symbols that override the symbol selected for go to definition only in the same source file as the one that was selected. This commit changes that, as suggested in the review of scala#5208.
Duhemm
force-pushed
the
topic/ide-multi-project-rename
branch
from
2a64545 to
72053ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can still be failures when we renaming symbols that appear in imports and late-compilation happens. This particular case is fixed in #5276.