Scaladoc: improve refined function types rendering #20333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florian3k
force-pushed
the
fix-19967
branch
2 times, most recently
from
9d23b58
to
72ef729
Compare
jchyb
approved these changes
May 6, 2024
Comment on lines
+407
to
+408
| private def isContextualMethod(using Quotes)(mt: reflect.MethodType) = | ||
| mt.asInstanceOf[dotty.tools.dotc.core.Types.MethodType].isContextualMethod |
There was a problem hiding this comment.
As a curiosity I will mention we've just added a MethodTypeKind to quotes api for that (but I think using the compiler directly here is better, and avoiding MethodTypeKind should allow us to use this scaladoc for LTS api).
WojciechMazur
pushed a commit
to WojciechMazur/dotty
that referenced
this pull request
May 6, 2024
Fixes scala#19967 Improves rendering of refined function types - unneeded parameters names are omitted when possible
WojciechMazur
pushed a commit
that referenced
this pull request
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19967
Improves rendering of refined function types - unneeded parameters names are omitted when possible