Regression: Fix match type extraction of a MatchAlias #20111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this failed with: ``` 14 | val x: Base.ExtractValue[Sub[Int *: EmptyTuple]] = 1 | ^ | Found: (1 : Int) | Required: Base.ExtractValue[Sub[Int *: EmptyTuple]] | | Note: a match type could not be fully reduced: | | trying to reduce Base.ExtractValue[Sub[Int *: EmptyTuple]] | failed since selector Sub[Int *: EmptyTuple] | does not uniquely determine parameter v in | case Base.BaseOf[v] => v | The computed bounds for the parameter are: | v = Tuple.Head[Int *: EmptyTuple] ``` Because the match type logic incorrectly believed that `v` was a non-alias TypeBounds.
sjrd
approved these changes
Apr 5, 2024
smarter
changed the title
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 5, 2024
….4.2 Backports scala#20111 which fixes a regression introduced in 3.4.0.
smarter
added
the
backport:nominated
WojciechMazur
removed
the
backport:nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this failed with:
Because the match type logic incorrectly believed that
vwas a non-alias TypeBounds.This used to work in 3.3 and regressed in 3.4.0.