Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unnecessary language flag #19865

Merged

Conversation

nicolasstucki
Copy link
Contributor

At some point scala.compiletime.erasedValue was defined as erased and therefore we needed this flag. Now we special case erasedValue in the compiler to give it erased semantics without defining it as such.

Copy link
Contributor

@EugeneFlesselle EugeneFlesselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

At some point `scala.compiletime.erasedValue` was defined as erased and
therefore we needed this flag. Now we special case `erasedValue` in the
compiler to give it erased semantics without defining it as such.
@nicolasstucki nicolasstucki force-pushed the clenup-unnecessary-language-flag branch from 52febf8 to a543e8f Compare March 6, 2024 10:59
@nicolasstucki nicolasstucki merged commit 736ea2a into scala:main Mar 6, 2024
19 checks passed
@nicolasstucki nicolasstucki deleted the clenup-unnecessary-language-flag branch March 6, 2024 16:11
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants