Add custom matchers for completions (fuzzy search for presentation compiler) #19850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipwiech
reviewed
Mar 2, 2024
| val extMethodsInScope = termCompleter.scopeCompletions.toList.flatMap: | ||
| case (name, denots) => denots.collect: | ||
| case d: SymDenotation if d.isTerm && d.termRef.symbol.is(Extension) => (d.termRef, name.asTermName) | ||
| val termCompleter = new Completer(Mode.Term, prefix, pos, _.startsWith(prefix)) |
There was a problem hiding this comment.
Sorry if the question doesn't make much sense, I'm not really familiar with this code, but does it mean that extension methods will be excluded from the fuzzy search? 🙂
In any case, great to see this improvement finally coming to Scala 3 completions! 👍
There was a problem hiding this comment.
This is my oversight. It should also be fuzzy. Great catch 👍🏻
kasiaMarek
reviewed
Apr 12, 2024
kasiaMarek
approved these changes
Apr 12, 2024
olhotak
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 15, 2024
…mpiler) (scala#19850) Fixes scalameta/metals#4656 Fixes scala#5507 Fixes scala#17706 To ensure CI output will be the same on all runners, I'm scheduling runs on all jvm versions + windows. [test_windows_full] [test_java8] [test_java11] [test_java15] [test_java17] [test_java18] [test_java19]
tgodzik
added
the
area:presentation-compiler
WojciechMazur
added a commit
that referenced
this pull request
Jul 5, 2024
…mpiler) (#19850) Fixes scalameta/metals#4656 Fixes #5507 Fixes #17706 To ensure CI output will be the same on all runners, I'm scheduling runs on all jvm versions + windows. [test_windows_full] [test_java8] [test_java11] [test_java15] [test_java17] [test_java18] [test_java19] [Cherry-picked acfc621][modified]
WojciechMazur
added a commit
that referenced
this pull request
Jul 5, 2024
…mpiler) (#19850) Fixes scalameta/metals#4656 Fixes #5507 Fixes #17706 To ensure CI output will be the same on all runners, I'm scheduling runs on all jvm versions + windows. [test_windows_full] [test_java8] [test_java11] [test_java15] [test_java17] [test_java18] [test_java19] [Cherry-picked acfc621][modified]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scalameta/metals#4656
Fixes #5507
Fixes #17706
To ensure CI output will be the same on all runners, I'm scheduling runs on all jvm versions + windows.
[test_windows_full]
[test_java8]
[test_java11]
[test_java15]
[test_java17]
[test_java18]
[test_java19]