Fix #19445: Remove too-strict test in match type matching. #19511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, for a `BaseTypeTest`, we explicitly checked the prefix of the type constructor for `=:=`. This is however too strict, as shown by scala#19445. We remove the test entirely, as the correct subprefixing test is already part of the overall `scrut <:< instantiatedPat` done at the end.
odersky
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for a
BaseTypeTest, we explicitly checked the prefix of the type constructor for=:=. This is however too strict, as shown by #19445. We remove the test entirely, as the correct subprefixing test is already part of the overallscrut <:< instantiatedPatdone at the end.